[gobolinux-devel] [gobolinux-commits] tools/Scripts/bin UpdateSettings

Jonas Karlsson jonka750 at student.liu.se
Mon Nov 13 20:08:53 UTC 2006


2006/11/13, Dan <theyranos at gmail.com>:
> CVSROOT:        /sources/goboscripts
> Module name:    tools
> Changes by:     Dan <drmoose>   06/11/13 16:36:36
>
> Modified files:
>        Scripts/bin    : UpdateSettings
>
> Log message:
>        Replacement for Is_Nonempty_Directory added when checking for the existance of previous and current settings.
>
>        I think that this, in combination with Jonas's fixes, should have #13 pretty much fixed.
>
I think that this change wasn't really needed after my fix. I even
think this is a regression. Even though Is_Nonempty_Directory would
return true in case there was a CVS folder, further down the function
'dirs_differ' would return false if the difference was only CVS
folders. The regression, imo, is that now that directories are
completly ignored, empty directories in Resources/Defaults/Settings
aren't propagated to /Programs/App/Settings. I don't know if it is a
wanted behaviour, but I can see its uses (skeleton).
If empty directories should be ignored this fix should stand,
otherwice we should revert.

-- 
/Jonas


More information about the gobolinux-devel mailing list