[gobolinux-devel] [gobolinux-commits] tools/Compile/bin RecipeLint

[Jonas Karlsson]

On Mon, 20 Nov 2006 21:21:55 +0100, Hisham Muhammad <hisham at apple2.com>  
wrote:

> CVSROOT:	/cvsroot/goboscripts
> Module name:	tools
> Changes by:	Hisham Muhammad <hisham>	06/11/20 20:21:55
>
> Modified files:
> 	Compile/bin    : RecipeLint
>
> Log message:
> 	Reverting -- pattern matching was incorrect (couldn't handle things such
> 	as "foo = 3.0", handling of spaces, etc.);
I don't get this message. First it does handle spaces. What strings have  
you tried it on? Could I see some error message regarding spaces  
erroneously detected. Second I didn't realize that '=' was a valid  
operand. I'll can't recall if there was a message stating the exact syntax  
of the operators, I can't seem to find any now, but I looked at  
CheckDependencies instead and there the operators where >,<,>=,<=  
("s_operand='(<|>|<=|>=)'"), so I went with those.

> full support would be equivalent
> 	to reimplementing the parser that already exists in CheckDependencies  
> (which
> 	is being used by RecipeLint, anyway). To improve checking of  
> dependencies,
> 	the right approach is to improve the communication between RecipeLint  
> and
> 	CheckDependencies (which is where dependency checking should take  
> place).
>
Dependency checks, yes, but syntax checks? I made this change to enforce  
users to notice the syntax change and that dependencies without operators  
are not guaranteed to work. I really want this check, but if it's possible  
to make it with CheckDependencies, ofcourse that'd be prefered.

-- 
/Jonas

Using Opera's revolutionary e-mail client: http://www.opera.com/mail/