[gobolinux-devel] [gobolinux-commits] tools/Scripts/bin SandboxInstall

[Jonas Karlsson]

On Fri, 20 Oct 2006 14:58:11 +0200, Lucas C. Villa Real  
<lucasvr at gobolinux.org> wrote:

> On 10/20/06, Jonas Karlsson <jonka750 at student.liu.se> wrote:
>> CVSROOT:        /sources/goboscripts
>> Module name:    tools
>> Changes by:     Jonas Karlsson <mohjive>        06/10/20 12:34:40
>>
>> Modified files:
>>         Scripts/bin    : SandboxInstall
>>
>> Log message:
>>         Fix for bu #2, cleaning up target directory when fibo sandbox  
>> fails
>
> I have been wondering about what to do with the program's contents in
> this case. The trace file you've attached to the bug shows that there
> was a binary file installed inside $target/bin.
>
> I think that we should take into account the user's choice on
> "existing entry at /Programs, [r]emove, [k]eep, [w]hatever" when
> cleaning up the broken installation: if the user has chosen to keep
> it, just use the fix you've just commited; if the user has chosen to
> remove it, the fix should also remove $target entirely.
>
> Does this look sane?
>
As it is now, all installed files are kept.
With union sandbox the sandbox target is kept, right? Are any files  
installed into $target? I think that, for fibo sandbox, removing $target  
completly is better, since then one got a predictable result, rather than  
a random outcome - what files were exactly installed and is it a working  
installation? My view is to try to have as little interactivity as  
possible, when avoidable.

-- 
/Jonas

Using Opera's revolutionary e-mail client: http://www.opera.com/mail/