[gobolinux-devel] symlinkprogram bug

[André Detsch]

Patch looks fine, but I would prefer to commit it right after 013 release.
Ok?

On 10/22/06, Jonas Karlsson <jonka750 at student.liu.se> wrote:
> On Sun, 22 Oct 2006 19:27:07 +0200, André Detsch <detsch at gmail.com> wrote:
>
> > Only --force (-f) is working. Looking at the code, it seems that the
> > introduction of --force has made the -c option being ignored.
> >
> My fault. Forgot that checks against passed options has to be done with
> the functions in OptionParser, and the not against the corresponding
> variable names.
> Suggested patch:
>
> diff -u -r1.30 SymlinkProgram
> --- SymlinkProgram      24 Sep 2006 11:12:11 -0000      1.30
> +++ SymlinkProgram      22 Oct 2006 18:45:25 -0000
> @@ -47,7 +47,8 @@
>   linkshared=`Entry "shared"`
>   linkwrappers=`Entry "wrappers"`
>
> -Boolean "force" && conflict="overwrite"
> +[ `Boolean "force"` -o `Entry "conflict"`=="overwrite" ] &&
> conflict="overwrite"
> +
>   ################################################################################
>
>   # Creates links from one directory into another.
>
> > On 10/22/06, Jonatan Liljedahl <lijon at kymatica.com> wrote:
> >> SymlinkProgram -c overwrite doesn't work. It doesn't overwrite...
> >>
>
> --
> /Jonas
>
> Using Opera's revolutionary e-mail client: http://www.opera.com/mail/
> _______________________________________________
> gobolinux-devel mailing list
> gobolinux-devel at lists.gobolinux.org
> http://lists.gobolinux.org/mailman/listinfo/gobolinux-devel
>


-- 
Andre Detsch