[gobolinux-devel] GenFstab

[Lucas C. Villa Real]

On 4/19/07, John E. Rose <jerose54 at gmail.com> wrote:
> >!
> I found several problems with the GenFstab in the 014RC ISO.
> 1) bootableflag and id require more of the "fdisk -l" output than is saved in
> the varable partition. I created a new variable pt to take care of this
> 2) the test 'test ! -z "${extralist}" && if echo "${extralist}" |
> grep -q "${drive}${partitionnumber}"' never reaches the else that unsets
> several variables if there is no extralist
> 3) "partitionnumber" is misspelled in one place ("partionnumber")
> 4) an incorrect line is added to the output if the id is 5
> 5) the arrays "types" and "drives" are not correctly expanded by $types and
> $drives; something like ${types[@]} is needed

Hey, good catch. We did some modifications to GenFstab, but they
weren't validated that much. Thanks for the fixes, I'm commiting them
right now.

-- 
Lucas
powered by /dev/dsp