[gobolinux-devel] Readding syntax check for Dependencies to RecipeLint

Jonas Karlsson jonka750 at student.liu.se
Sun Aug 26 18:45:59 UTC 2007


While talking about dependencies and such, I'd like to readd this patch to RecipeLint. Basically it makes RecipeLint perform a syntax check on the Dependencies file. The reason it was rejected last time was because this check was better placed in CheckDependencies. However I think it's better to add this now and remove it whenever the corresponding functionallity is added to CheckDependencies. It's better to have this basic checking than not having anything at all. Especially since we treat the old format as no version was specified and there are recipes created that use the old format, as that's how we copy it from BuildInformation, even if it really needed a lowest (and/or highest) version specified.

-- 
/Jonas

--- RecipeLint	18 Nov 2006 15:15:00 -0000	1.30
+++ RecipeLint	20 Nov 2006 20:21:55 -0000	1.31
@@ -683,15 +683,6 @@
        grep -q "^# \*Warning\*" $depfile && {
           ERROR "Dependencies file contains unmatched library dependencies."
        }
+      while read line
+      do
+         bad_dep=`echo $line | sed -r -e '/.*\ [><=]?\ .*/d' -e '/^#.*/d' -e '/^\s*$/d'`
+         if [ ! -z "$bad_dep" ]
+         then
+            WARN "Old style dependency/Bad line in Dependensies: $bad_dep"
+         fi
+      done < $depfile
+
        missing_deps() {
           CheckDependencies --types=$1 --mode=all --quiet-progress --no-recursive --no-blacklist --no-compatlist $name $version recipe $PWD | while read d_program d_version d_type d_url;
           do


More information about the gobolinux-devel mailing list