[gobolinux-devel] [gobolinux-commits] tools/ConfigTools/bin GenGrubMenu

[Jonas Karlsson]

On Wed, 16 Jan 2008 06:35:26 +0100, Lucas C. Villa Real <lucasvr at gobolinux.org> wrote:

> On Dec 2, 2007 4:03 AM, Jonas Karlsson <jonka750 at student.liu.se> wrote:
>> CVSROOT:        /sources/goboscripts
>> Module name:    tools
>> Changes by:     Jonas Karlsson <mohjive>        07/12/02 12:03:03
>>
>> Modified files:
>>         ConfigTools/bin: GenGrubMenu
>>
>> Log message:
>>         Grub always number the disk it boots from as '0'. If we install grub to mbr we probably live somewhere on that disk
>>
>> CVSWeb URLs:
>> http://cvs.savannah.gnu.org/viewcvs/tools/ConfigTools/bin/GenGrubMenu?cvsroot=goboscripts&r1=1.14&r2=1.15
>>
>> Patches:
>> Index: GenGrubMenu
>> ===================================================================
>> RCS file: /sources/goboscripts/tools/ConfigTools/bin/GenGrubMenu,v
>> retrieving revision 1.14
>> retrieving revision 1.15
>> diff -u -b -r1.14 -r1.15
>> --- GenGrubMenu 2 Dec 2007 11:56:11 -0000       1.14
>> +++ GenGrubMenu 2 Dec 2007 12:03:02 -0000       1.15
>> @@ -124,7 +124,7 @@
>>                 if len(l) > 1 and l[1] == '*' :
>>                         bootableWindowsPartitions.append(devToGrub(l[0]))
>>
>> -       grubFormatTarget = devToGrub('/dev/'+targetPartition)
>> +       grubFormatTarget = re.sub('[1-9],','0,',devToGrub('/dev/'+targetPartition))
>>         swapPartition = getSwapPartition()
>>
>>         o = ''
>
> Why was this commit necessary? I'm looking at bug #243, and it
> happened because of this change -- reverting to the old
> 'devToGrub('/dev/'+targetPartition)' fixes that. What problems did you
> have with the previous code?
>
It's because grub always think that the disk it is installed to is hd0.
So even if you install grub on hdb, which the bios probably would name
hd1, grub think of this device as hd0.  I have that setup here. This is
a workaround for that usercase, but it assumes grub and GoboLinux live
on the same device. I may have overlooked the usercase when grub was
installed onto a different device than GoboLinux.

-- 
/Jonas

Using Opera's revolutionary e-mail client: http://www.opera.com/mail/